89 commits

Author	SHA1	Message	Date
Matt Jankowski	469028b6d3	Remove unneeded type: :service from spec/services files (#29304)	2024-03-13 08:39:26 +00:00
Claire	9d8dfeb5fb	Fix processing of Link objects in Image objects (#29335)	2024-02-22 22:27:24 +01:00
Claire	9fee5e8526	Merge pull request from GHSA-jhrq-qvrm-qr36 ... * Fix insufficient Content-Type checking of fetched ActivityStreams objects * Allow JSON-LD documents with multiple profiles	2024-02-16 11:56:12 +01:00
Matt Jankowski	fc4f823464	Avoid local block var assignment in ap/process_status_update_service spec (#29210)	2024-02-16 07:41:25 +00:00
Matt Jankowski	978fdc71ca	Reduce expectation count in example from ProcessAccountService spec (#29100)	2024-02-06 13:04:02 +00:00
Claire	1726085db5	Merge pull request from GHSA-3fjr-858r-92rw ... * Fix insufficient origin validation * Bump version to 4.3.0-alpha.1	2024-02-01 15:56:46 +01:00
Matt Jankowski	44f6d285af	Combine repeated subject in ap fetch remote actor service spec (#28953)	2024-01-26 17:44:12 +00:00
Matt Jankowski	239244e2ed	Combine repeated subject in ap fetch remote account service spec (#28952)	2024-01-26 17:43:08 +00:00
Matt Jankowski	7c9c6c7f80	Fix remaining Rails/WhereExists cop violations, regenerate todo (#28892)	2024-01-25 12:37:07 +00:00
Claire	cf2a2ed71c	Fix processing of compacted single-item JSON-LD collections (#28816)	2024-01-19 12:43:10 +00:00
Matt Jankowski	00341c70ff	Use Sidekiq fake! instead of inline! in specs (#25369)	2024-01-10 11:06:58 +00:00
Matt Jankowski	a4d49c236d	Fix RSpec/LetSetup cop in ap/fetch_featured_collection_service (#28461)	2023-12-22 12:57:29 +00:00
Matt Jankowski	efd16f3c2c	Clean up of RSpec/LetSetup within spec/services/activitypub (#28445)	2023-12-21 11:20:12 +00:00
Matt Jankowski	5517df61de	Remove double subject call in services/activitypub/process_account_service spec (#28214)	2023-12-06 08:44:51 +00:00
Matt Jankowski	bb0efe16e6	Remove default_scope from MediaAttachment class (#28043)	2023-11-30 13:30:35 +00:00
Matt Jankowski	b2c5b20ef2	Fix RSpec/AnyInstance cop (#27810)	2023-11-14 14:52:59 +00:00
Matt Jankowski	49e2772064	Fix RSpec/MessageSpies cop (#27751)	2023-11-07 09:46:28 +00:00
Jeong Arm	8f998cd96a	Handle featured collections without items (#27581)	2023-10-27 02:36:22 +00:00
Claire	6273416292	Fix post edits not being forwarded as expected (#26936)	2023-09-15 19:54:32 +02:00
Matt Jankowski	2d9808f648	Reformat large key values in service specs (#26181)	2023-07-26 09:45:50 +02:00
Matt Jankowski	6c5a2233a8	Fix RSpec/StubbedMock cop (#25552) ... Co-authored-by: Claire <claire.github-309c@sitedethib.com>	2023-07-12 10:20:10 +02:00
Matt Jankowski	658742b3cd	Fix Lint/AmbiguousBlockAssociation cop (#25921)	2023-07-12 10:02:41 +02:00
Matt Jankowski	c75df62ccc	Fix RSpec/SubjectDeclaration cop (#25312)	2023-07-12 09:49:33 +02:00
Matt Jankowski	4c5aa0e470	Update rubocop-rspec to version 2.22.0, fix RSpec/IndexedLet cop (#24698)	2023-06-14 16:44:37 +02:00
Matt Jankowski	c42591356d	Fix RSpec/DescribedClass cop (#25104)	2023-06-06 13:58:33 +02:00
Nick Schonning	99e2e9b81f	Fix minor typos in comments and spec names (#21831)	2023-05-19 17:13:29 +02:00
Matt Jankowski	a610a02d4f	Fix RSpec/ScatteredSetup cop (#24848)	2023-05-11 10:32:09 +02:00
Matt Jankowski	710745e16b	Fix RSpec/ContextWording cop (#24739)	2023-05-04 05:49:08 +02:00
Nick Schonning	a3393d0d07	Autofix Rubocop RSpec/MatchArray (#24050)	2023-04-26 20:21:54 +02:00
Nick Schonning	84cc805cae	Enable Style/FrozenStringLiteralComment for specs (#23790)	2023-02-22 09:55:31 +09:00
Nick Schonning	5116347eb7	Autofix Rubocop RSpec/BeEq (#23740)	2023-02-20 06:14:50 +01:00
Nick Schonning	bf785df9fe	Audofix Rubocop Style/WordArray (#23739)	2023-02-20 06:14:10 +01:00
Nick Schonning	4552685f6b	Autofix Rubocop RSpec/LeadingSubject (#23670)	2023-02-20 13:24:14 +09:00
Nick Schonning	5179c47087	Autofix Rubocops RSpec/ScatteredLet (#23725)	2023-02-20 11:17:41 +09:00
Nick Schonning	65ba0d92ef	Enable Rubocop RSpec/NotToNot (#23723)	2023-02-20 02:33:27 +01:00
Nick Schonning	81ad6c2e39	Autofix Rubocop Style/StringLiterals (#23695)	2023-02-19 07:38:14 +09:00
Nick Schonning	08289a38fa	Autofix Rubocop Style/TrailingCommaInArrayLiteral (#23692)	2023-02-19 06:54:30 +09:00
Nick Schonning	5069769cbe	Autofix Rubocop Style/TrailingCommaInHashLiteral (#23693)	2023-02-18 23:33:41 +09:00
Nick Schonning	634368c491	Autofix Rubocop Lint/SymbolConversion (#23683)	2023-02-18 03:23:49 +01:00
Nick Schonning	669f6d2c0a	Run rubocop formatting except line length (#23632)	2023-02-18 06:56:20 +09:00
Nick Schonning	37914c8757	Autofix Rubocop Style/MethodCallWithoutArgsParentheses (#23645)	2023-02-17 21:36:14 +09:00
Claire	0c9eac80d8	Fix unbounded recursion in post discovery (#23506) ... * Add a limit to how many posts can get fetched as a result of a single request * Add tests * Always pass `request_id` when processing `Announce` activities --------- Co-authored-by: nametoolong <nametoolong@users.noreply.github.com>	2023-02-10 22:16:37 +01:00
Claire	c8849d6cee	Fix unbounded recursion in account discovery (#22025) ... * Fix trying to fetch posts from other users when fetching featured posts * Rate-limit discovery of new subdomains * Put a limit on recursively discovering new accounts	2022-12-07 00:15:24 +01:00
Claire	625216d8e1	Fix attachments of edited statuses not being fetched (#21565) ... * Fix attachments of edited statuses not being fetched * Fix tests	2022-11-27 20:39:05 +01:00
Claire	bbf74498f5	Fix validation error in SynchronizeFeaturedTagsCollectionWorker (#20018) ... * Fix followers count not being updated when migrating follows Fixes #19900 * Fix validation error in SynchronizeFeaturedTagsCollectionWorker Also saves remote user's chosen case for hashtags * Limit remote featured tags before validation	2022-11-07 22:35:53 +01:00
Yamagishi Kazutoshi	94feb2b93f	Fix FetchFeaturedCollectionService spec (#19401) ... Regression from #19380	2022-10-21 11:48:22 +02:00
Claire	7165e89362	Add tests to ActivityPub::FetchRemoteKeyService (#19226)	2022-09-24 08:33:27 +02:00
Claire	8cf7006d4e	Refactor ActivityPub handling to prepare for non-Account actors (#19212) ... * Move ActivityPub::FetchRemoteAccountService to ActivityPub::FetchRemoteActorService ActivityPub::FetchRemoteAccountService is kept as a wrapper for when the actor is specifically required to be an Account * Refactor SignatureVerification to allow non-Account actors * fixup! Move ActivityPub::FetchRemoteAccountService to ActivityPub::FetchRemoteActorService * Refactor ActivityPub::FetchRemoteKeyService to potentially return non-Account actors * Refactor inbound ActivityPub payload processing to accept non-Account actors * Refactor inbound ActivityPub processing to accept activities relayed through non-Account * Refactor how Account key URIs are built * Refactor Request and drop unused key_id_format parameter * Rename ActivityPub::Dereferencer `signature_account` to `signature_actor`	2022-09-21 22:45:57 +02:00
Claire	1145dbd327	Improve error reporting and logging when processing remote accounts (#15605) ... * Add a more descriptive PrivateNetworkAddressError exception class * Remove unnecessary exception class to rescue clause * Remove unnecessary include to JsonLdHelper * Give more neutral error message when too many webfinger redirects * Remove unnecessary guard condition * Rework how “ActivityPub::FetchRemoteAccountService” handles errors Add “suppress_errors” keyword argument to avoid raising errors in ActivityPub::FetchRemoteAccountService#call (default/previous behavior). * Rework how “ActivityPub::FetchRemoteKeyService” handles errors Add “suppress_errors” keyword argument to avoid raising errors in ActivityPub::FetchRemoteKeyService#call (default/previous behavior). * Fix Webfinger::RedirectError not being a subclass of Webfinger::Error * Add suppress_errors option to ResolveAccountService Defaults to true (to preserve previous behavior). If set to false, errors will be raised instead of caught, allowing the caller to be informed of what went wrong. * Return more precise error when failing to fetch account signing AP payloads * Add tests * Fixes * Refactor error handling a bit * Fix various issues * Add specific error when provided Digest is not 256 bits of base64-encoded data * Please CodeClimate * Improve webfinger error reporting	2022-09-20 23:30:26 +02:00
Claire	e0bdaeab65	Fix NoMethodError when resolving a link that redirects to a local post (#18314) ... * Fix NoMethodError when resolving a link that redirects to a local post * Fix tests	2022-05-17 14:52:26 +02:00